I have tried several different methods to upload a file and update the associated items for the file and I always get the following error:
To add an item to a document library, use SPFileCollection.Add()

My code is as follows:

if (htmlFileUpload.PostedFile != null)
{
int found;
string libraryName = "Employee Availability Resumes";
string fileExt = "";
string destUrl = strDocLibUrl;
string uploadedFile = htmlFileUpload.PostedFile.FileName;
found = uploadedFile.IndexOf(".");
fileExt = uploadedFile.Substring(found).Trim();
using (SPWeb web = new SPSite(destUrl).OpenWeb())
{
try
{
SPList list = web.Lists[libraryName];
if (list != null)
{
web.AllowUnsafeUpdates = true;
SPListItem item = list.Items.Add();
item["Employee Number"] = txtEmpNo.Text;
item["Tracking ID"] = strTrackingId;

if (htmlFileUpload.PostedFile != null)
{
Stream fStream = htmlFileUpload.PostedFile.InputStream;
byte[] contents = new byte[fStream.Length];
fStream.Read(contents, 0, (int)fStream.Length);
fStream.Close();
fStream.Dispose();
string fileName = Path.GetFileName(htmlFileUpload.PostedFile.FileName);
SPFile newFile = list.RootFolder.Files.Add(fileName, contents, true);
}
item.Update();
web.AllowUnsafeUpdates = false;
}
return true;
}

Any help on this would be greatly appreciated.
Thanks,
Brian

Hi Brian,
I think you should first upload the file to the library and then update its properties. Adding a new list item first will probably not work.

Based on your code I've slightly adapted it to what I think should work (without having actually tried out the code so no promises here):

if (htmlFileUpload.PostedFile != null)
{
int found;
string libraryName = "Employee Availability Resumes";
string fileExt = "";
string destUrl = strDocLibUrl;
string uploadedFile = htmlFileUpload.PostedFile.FileName;
found = uploadedFile.IndexOf(".");
fileExt = uploadedFile.Substring(found).Trim();
using (SPWeb web = new SPSite(destUrl).OpenWeb())
{
try
{
SPList list = web.Lists[libraryName];
if (list != null)
{
web.AllowUnsafeUpdates = true;

Stream fStream = htmlFileUpload.PostedFile.InputStream;
byte[] contents = new byte[fStream.Length];
fStream.Read(contents, 0, (int)fStream.Length);
fStream.Close();
fStream.Dispose();
string fileName = Path.GetFileName(htmlFileUpload.PostedFile.FileName);
SPFile newFile = list.RootFolder.Files.Add(fileName, contents, true);

Hashtable fileProps = file.Properties;
fileProps["Employee Number"] = txtEmpNo.Text;
fileProps["Tracking ID"] = strTrackingId;
file.Update();

web.AllowUnsafeUpdates = false;
}
return true;
}
catch (System.Exception exc)
{
//error handling}
}

}
}

Katrien,

It worked like a charm (after I changed file.Properties and file.Update to newFile.Properties and newFile.Update).

This one had me stumped for several days so thank you very much!!

Brian

Glad it worked Brian,
As I said, I changed the code without actually compiling or testing it ;-)

Thx man! :D

Thanks this was very handy. Worked straight off.

Thanks man... your code works perfectly!

Hi,

I am using the SPFile.Update() method as above to alter some meta data properties of a file in a sharepoint list. This works fine except I cannot update the Name or Title of the document just the other properties I have created.

fileProperties["Name"] = newNameString;
file.Update();

I am trying to upload multiple versions of the same file keeping the version history however the file name may have changed between versions but I am unable to change a file name for an existing document! I have tried various options but no joy!

Any ideas?

Thanks,

Tim

Well, this post certainly is old, but just in case anyone googles this:

The metadata is not updated via the update method of the SPFile object as this is a representation of the actual file while the metadata is attached to the list item representation of the file.
To update the metdata you have change the data of the item and then update the list item, not the file itself:

file.Item["somedescriptor"] = somevalue;
file.Item.Update();

Great Post!! It helped me Uploading a document to the document library & updating columns also.

Hello Katrien,

Uploading the attachment file is worked fine for me. Thanks for providing this but now I'm facing the problem with showing the attachment image in grid with specific size is not getting to me. Can you tell me how to control the attached image width and height size in sharepoint webpart.

Thanks in advance,
Madan